Add plugin sample #3644
Add plugin sample #3644
Conversation
There was a problem hiding this comment.
Thanks for this PR.
We have plans to improve documentation on writing providers (#681, for this page), we could also have a page on how to write a plugin.
We usually add samples with the corresponding conceptual documentation; a code sample alone (such as this) isn't easily discoverable by users looking at the docs. If the goal is simply to have a working plugin source to look at, then simply pointing to e.g. the NetTopologySuite source code may be enough.
Note also that this sample shows only IMethodCallTranslatorPlugin, but there are other plugin types (e.g. ITypeMappingSourcePlugin, IEvaluatableExpressionFilterPlugin, IConventionSetPlugin...).
|
Hi @roji, This PR was started in an attempt to reproduce a possible bug in EF Core PawelGerr/Thinktecture.EntityFrameworkCore#17 I didn't find an existing test case to modify in dotnet/efcore, because I'm either not familiar with it or because it wasn't there. Still hoping to reproduce the issue, but in the meantime the PR was a good exercise for me to isolate the plugin concept. If the PR gets merged and helps someone else - that's a bonus. |
|
Issue dotnet/efcore#27075 was the original reason for this PR |
|
@virzak we've discussed this internally, and the decision is that we prefer not to add standalone code samples that aren't part of corresponding conceptual documentation. In other words, something like this would definitely make sense as part of #681, but we don't think that having the code without any docs is very helpful. Good luck with your bug and let us know if you need any help. |
|
I'm not sure a plugin/README.md would be very discoverable either - I think at some point we need to do #681... |
No description provided.